ci: Allow to overwrite the ko base image path #1688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomazpu
previously approved these changes
Feb 10, 2025
Laubi
force-pushed
the
ci/use-docker-proxy
branch
from
b73f7f6 to
cd4ed66
Compare
In the Makefile. You specify |
Laubi
force-pushed
the
ci/use-docker-proxy
branch
from
cd4ed66 to
ad52fcd
Compare
This allows us to use a different proxy instead of querying docker directly, potentially breaking the pipeline because of "You have reached your pull rate limit". By default, it still pulls from docker hub
Laubi
force-pushed
the
ci/use-docker-proxy
branch
from
ad52fcd to
874a9bc
Compare
|
tomazpu
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / Why we need it:
This change allows us to use a different proxy instead of querying docker directly, potentially breaking the pipeline because of "You have reached your pull rate limit".
By default, it still pulls from the docker-hub
Documentation about ko: https://ko.build/configuration/
Special notes for your reviewer:
Does this PR introduce a user-facing change?
no