Add del2,del4 source terms to manufactured solution #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
hyungyukang
reviewed
Dec 3, 2024
components/mpas-ocean/src/shared/mpas_ocn_manufactured_solution.F
Outdated
Show resolved
Hide resolved
components/mpas-ocean/src/shared/mpas_ocn_manufactured_solution.F
Outdated
Show resolved
Hide resolved
sbrus89
reviewed
Dec 3, 2024
Co-authored-by: Hyun (Hyun-Gyu) Kang <[email protected]>
cbegeman
force-pushed
the
ocn/enhance-manufactured-solution
branch
from
41827e8 to
30fb3a6
Compare
|
@hyungyukang and @sbrus89 I have made the requested changes and tested del2 and del4 with the polaris test case. Can you re-review whenever it's convenient? Thanks! |
hyungyukang
approved these changes
Dec 19, 2024
|
@hyungyukang and @sbrus89 thank you both so much for your reviews, especially @hyungyukang for finding those bugs! |
|
Closed in favor of E3SM-Project#6862 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When either or both of del2 and del4 momentum terms are included in the dynamics, add the corresponding source terms to the manufactured solution.