Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise forcing specifications for single forcing compsets #6790

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

wlin7
Copy link
Contributor

@wlin7 wlin7 commented Dec 2, 2024

Revisions to single-forcing compsets' forcing specification focusing on
where to include the GHG warming contribution of CH4, N2O, and O3 due to
v3atm's interactive chemistry.

Core to the changes is to separate the transient aerosol and chemical precursors for different
single forcing compsets. New virtually transient forcing files are introduced to satisfy the unified data
stream control for surface and elevated emissions. Historical evolution of stratospheric ozone
is moved from the all-else configuration to the GHG only configuration.

Fixes #6837

[BFB] non-BFB only for single forcing compsets
[NML] Different only for single forcing compsets


Related info

Review Guide

Revision to composition of forcings (changes in dark red)
image
image

No changes for hist-nat, hist-ozone, hist-lulc, and hist-volc. hist-ozone is limited to stratospheric zone changes.

Copy link
Contributor

@mahf708 mahf708 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all single-forcing compsets should be updated in sync; otherwise, they should be deleted.

@rljacob
Copy link
Member

rljacob commented Dec 2, 2024

Please create an issue describing the problem.

@wlin7
Copy link
Contributor Author

wlin7 commented Dec 2, 2024

I think all single-forcing compsets should be updated in sync; otherwise, they should be deleted.

Sure, @mahf708 . All will be updated. Some modified forcing files (in time varying format) are not ready. Decision on treatment of ozone, esp. stratospheric is also to be made.

@@ -44,19 +42,19 @@
<ch3coch3_emis_file >atm/cam/chem/trop_mozart_aero/emis/chem_gases/2degrees/emissions-cmip6_e3sm_CH3COCH3_surface_1850-2014_1.9x2.5_c20210323.nc </ch3coch3_emis_file>
<co_emis_file >atm/cam/chem/trop_mozart_aero/emis/chem_gases/2degrees/emissions-cmip6_e3sm_CO_surface_1850-2014_1.9x2.5_c20210323.nc </co_emis_file>
<isop_emis_file >atm/cam/chem/trop_mozart_aero/emis/chem_gases/2degrees/emissions-cmip6_e3sm_ISOP_surface_1850-2014_1.9x2.5_c20210323.nc </isop_emis_file>
<isop_vbs_emis_file >atm/cam/chem/trop_mozart_aero/emis/chem_gases/2degrees/emissions-cmip6_e3sm_ISOP_surface_1850-2014_1.9x2.5_c20210323.nc </isop_vbs_emis_file>
<isop_vbs_emis_file >atm/cam/chem/trop_mozart_aero/emis/single_forcings/surf/emissions-cmip6_e3sm_ISOP_surface_1850-2014_1.9x2.5_c20210323_1850_repeated_c20241122.nc </isop_vbs_emis_file>
<c10h16_emis_file >atm/cam/chem/trop_mozart_aero/emis/chem_gases/2degrees/emissions-cmip6_e3sm_MTERP_surface_1850-2014_1.9x2.5_c20230126.nc </c10h16_emis_file>
Copy link
Contributor Author

@wlin7 wlin7 Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per @keziming and @tangq , C10H16 (MTERP) is a precursor gas for VBS-aerosol not a UCI-chemistry reactant. Keep it at 1850 level for hist-GHG and use its historical evolution for hist-aer.

@wlin7 wlin7 changed the title WIP: Revise forcing specifications for single forcing compsets Revise forcing specifications for single forcing compsets Dec 5, 2024
@wlin7
Copy link
Contributor Author

wlin7 commented Dec 5, 2024

Hello reviewers, this PR is ready for review and testing. Please refer to the review guide in the PR description. Thanks.
Pinging @golaz @tangq @mahf708 @kaizhangpnl @keziming

Copy link
Contributor

@mahf708 mahf708 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving

a minor suggestion for additional review of the monoterpene setting by colleagues

<ch3cho_emis_file >atm/cam/chem/trop_mozart_aero/emis/single_forcings/surf/emissions-cmip6_e3sm_CH3CHO_surface_1850-2014_1.9x2.5_c20210323_1850_repeated_c20241122.nc </ch3cho_emis_file>
<ch3coch3_emis_file >atm/cam/chem/trop_mozart_aero/emis/single_forcings/surf/emissions-cmip6_e3sm_CH3COCH3_surface_1850-2014_1.9x2.5_c20210323_1850_repeated_c20241122.nc </ch3coch3_emis_file>
<co_emis_file >atm/cam/chem/trop_mozart_aero/emis/single_forcings/surf/emissions-cmip6_e3sm_CO_surface_1850-2014_1.9x2.5_c20210323_1850_repeated_c20241122.nc </co_emis_file>
<isop_emis_file >atm/cam/chem/trop_mozart_aero/emis/single_forcings/surf/emissions-cmip6_e3sm_ISOP_surface_1850-2014_1.9x2.5_c20210323_1850_repeated_c20241122.nc </isop_emis_file>
<isop_vbs_emis_file >atm/cam/chem/trop_mozart_aero/emis/chem_gases/2degrees/emissions-cmip6_e3sm_ISOP_surface_1850-2014_1.9x2.5_c20210323.nc </isop_vbs_emis_file>
<c10h16_emis_file >atm/cam/chem/trop_mozart_aero/emis/chem_gases/2degrees/emissions-cmip6_e3sm_MTERP_surface_1850-2014_1.9x2.5_c20230126.nc </c10h16_emis_file>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this monoterpene (C10H16) specification is okay as-is. However, I strongly recommend a review from Kai, Mingxuan and Hailong before adopting this as they know this stuff much more than me ... cc @mingxuanwupnnl @kaizhangpnl @hwangacme

Copy link
Contributor

@tangq tangq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wlin7 , thanks for putting these changes together. They look great to me. Thanks!

Copy link
Contributor

@golaz golaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The revised partitioning of the various forcings between hist-GHG, hist-aer, hist-xGHG-xaer looks fine and is consistent with what we discussed, including separation between chemical and aerosol precursors. I have not checked the details of the implementation and xml changes.

@rljacob
Copy link
Member

rljacob commented Dec 6, 2024

For the record, how was this tested? Also, please create an issue describing the problem. All the v3.0 bugs should have issues for them.

Copy link
Contributor

@kaizhangpnl kaizhangpnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me.

PS: We need to output the green house gas concentrations if they are varying in the simulation.

@wlin7
Copy link
Contributor Author

wlin7 commented Dec 6, 2024

For the record, how was this tested? Also, please create an issue describing the problem. All the v3.0 bugs should have issues for them.

@rljacob , the issue is now described in #6837. As for the test, did you mean something for the nightly? Don't have yet. If you meant the settings themselves, it was done by inspecting the settings in use_case files against the intended specifications (and the revision this time around).

@wlin7 wlin7 self-assigned this Dec 6, 2024
@wlin7 wlin7 merged commit 4d8ef77 into maint-3.0 Dec 6, 2024
8 checks passed
@wlin7 wlin7 deleted the wlin/atm/revised_single_forcings branch December 6, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants