Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EAMxx: reorganize files related to query-cf-database utility #6861

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

bartgol
Copy link
Contributor

@bartgol bartgol commented Dec 19, 2024

Doing some cleaning: these files were built along with eamxx in certain conditions, despite being never used.


In particular

  • Moved query-cf-database to its own folder inside scripts
  • Do not add scripts subdir when building EAMxx
  • Move data/*yaml in query-cf-database folder

Fixes #6863

* Moved to its own folder
* Do not add scripts subdir when building EAMxx
* Move data/*yaml in query-cf-database folder
@bartgol bartgol added Scripts BFB PR leaves answers BFB EAMxx PRs focused on capabilities for EAMxx code cleanup labels Dec 19, 2024
@bartgol bartgol requested a review from jgfouca December 19, 2024 19:53
@bartgol bartgol self-assigned this Dec 19, 2024
Copy link

github-actions bot commented Dec 19, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6861/
on branch gh-pages at 2024-12-20 16:12 UTC

The folder eamxx/data no longer exists, and did not contain any input
data for EAM in the first place
@ndkeen
Copy link
Contributor

ndkeen commented Dec 19, 2024

Fixes #6863

@bartgol
Copy link
Contributor Author

bartgol commented Jan 6, 2025

Since this does touch an important file in EAM, although it seems impossible that the mods have any effect, I'm going to merge to next, and wait till tomorrow.

bartgol added a commit that referenced this pull request Jan 6, 2025
@bartgol
Copy link
Contributor Author

bartgol commented Jan 7, 2025

The fails on next are not due to this PR. Merging.

@bartgol bartgol merged commit fbc8289 into master Jan 7, 2025
20 of 23 checks passed
@bartgol bartgol deleted the bartgol/eamxx/do-not-build-scripts-dir-with-cmake branch January 7, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB code cleanup EAMxx PRs focused on capabilities for EAMxx Scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build error when trying to upgrade cmake version (to 3.30) for GPU builds (on pm-gpu at least)
3 participants