Fix steps_to_run for shared config files
#134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xylar
added
bug
|
This should fix #120 (comment). |
With this merge, each task that uses a shared config file used by a task to be set up has its configure() method called and then `steps_to_run` is added to the shared config options. This prevents a situation where `steps_to_run` is missing when a task is set up later that overwrites the shared config file.
xylar
force-pushed
the
fix-steps-to-run-shared-config
branch
from
2575c01 to
2c6adfd
Compare
TestingI set up: Then, I ran: This worked with this branch whereas a similar test failed in #120 (comment) |
6 tasks
|
@sbrus89, thank you for finding this problem. Please let me know if this fixes it for you. |
|
@sbrus89, same here, I'm going to count on my testing and not waste your time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this merge, each task that uses a shared config file used by a task to be set up has its configure() method called and then
steps_to_runis added to the shared config options. This prevents a situation wheresteps_to_runis missing when a task is set up later that overwrites the shared config file.Checklist
Testingcomment in the PR documents testing used to verify the changes