Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple tasks to be set up with -t flag #135

Merged
merged 1 commit into from
Oct 28, 2023

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Oct 13, 2023

This merge changes the -t or --tasks flag to polaris setup to allow multiple task to be specified.

Since there is not a sensible way to specify cached steps for each of several tasks, the --cached flag only works when a single task is specified to to -t or -n.

Checklist

  • User's Guide has been updated
  • Developer's Guide has been updated
  • Documentation has been built locally and changes look as expected
  • Testing comment in the PR documents testing used to verify the changes

This merge changes the `-t` or `--tasks` flag to `polaris setup`
to allow multiple task to be specified.

Since there is not a sensible way to specify cached steps for
each of several tasks, the `--cached` flag only works when a
single task is specified to to `-t` or `-n`.
@xylar xylar added enhancement New feature or request framework Changes relating to the polaris framework as opposed to individual tests or analysis labels Oct 13, 2023
@xylar xylar requested a review from sbrus89 October 13, 2023 08:59
@xylar xylar self-assigned this Oct 13, 2023
@xylar
Copy link
Collaborator Author

xylar commented Oct 13, 2023

Testing

I was able to set up and run the single-column ocean tests on my laptop:

$ polaris setup -t ocean/single_column/cvmix ocean/single_column/ideal_age -p ...

Then,

$ source load_polaris_env.sh 
$ plaris serial
ocean/single_column/cvmix
  * step: init
          execution:        SUCCESS
          runtime:          0:00:01
  * step: forward
          execution:        SUCCESS
          runtime:          0:00:02
  * step: viz
          execution:        SUCCESS
          runtime:          0:00:01
  task execution:   SUCCESS
  task runtime:     0:00:04
ocean/single_column/ideal_age
  * step: init
          execution:        SUCCESS
          runtime:          0:00:01
  * step: forward
          execution:        SUCCESS
          runtime:          0:00:02
  * step: viz
          execution:        SUCCESS
          runtime:          0:00:01
  task execution:   SUCCESS
  task runtime:     0:00:04
Task Runtimes:
0:00:04 PASS ocean/single_column/cvmix
0:00:04 PASS ocean/single_column/ideal_age
Total runtime: 0:00:08
PASS: All passed successfully!

@xylar
Copy link
Collaborator Author

xylar commented Oct 13, 2023

@sbrus89, this is ready to review.

@xylar
Copy link
Collaborator Author

xylar commented Oct 16, 2023

@sbrus89, since this was a feature request, I'm going to leave it for you to review, unlike the recent bug fixes.

@xylar xylar removed the request for review from sbrus89 October 28, 2023 14:08
@xylar xylar merged commit a3675ab into E3SM-Project:main Oct 28, 2023
5 checks passed
@xylar xylar deleted the setup-multiple-tasks branch October 28, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request framework Changes relating to the polaris framework as opposed to individual tests or analysis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant