Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix conversion to absolute paths in config files #136

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Fix conversion to absolute paths in config files #136

merged 1 commit into from
Oct 16, 2023

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Oct 16, 2023 •
edited
Loading

We don't want to do this for config options that start with other config options.

Checklist

  • Testing comment in the PR documents testing used to verify the changes

@xylar
Fix conversion to absolute paths in config files
72507ce 
We don't want to do this for config options that start with
other config options.
@xylar xylar added bug Something isn't working framework Changes relating to the polaris framework as opposed to individual tests or analysis labels Oct 16, 2023
@xylar xylar requested a review from sbrus89 October 16, 2023 16:53
@xylar xylar self-assigned this Oct 16, 2023
@xylar
Copy link
Collaborator Author

xylar commented Oct 16, 2023

@sbrus89, can you see if this fixes the bug you reported in #120 (comment)?

@xylar
Copy link
Collaborator Author

xylar commented Oct 16, 2023

Testing

I ran the pr suite with this branch on Chrysalis, using main as a baseline and omitting the -p flag in both cases. Whereas the baseline failed for both the baroclinic channel restart and inertial gravity wave tests, all tests succeeded in this branch and were BFB with the baseline for all tests that succeeded in the baseline.

@xylar xylar mentioned this pull request Oct 16, 2023
Merged
1 task
@xylar xylar removed the request for review from sbrus89 October 16, 2023 20:33
@xylar
Copy link
Collaborator Author

xylar commented Oct 16, 2023

@sbrus89, so not overwhelm your precious time, I'm going to just merge some of these based on my testing.

@xylar xylar merged commit 7bffbf4 into E3SM-Project:main Oct 16, 2023
@xylar xylar deleted the fix-registry-abs-path-bug branch October 16, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@xylar xylar

Labels
bug Something isn't working framework Changes relating to the polaris framework as opposed to individual tests or analysis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xylar