Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Separate geostrophic thresholds for h and norm. vel. #139

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Oct 20, 2023

We want to have a higher threshold on velocity convergence since it is better behaved than water-column thickness.

Checklist

  • User's Guide has been updated
  • Testing comment in the PR documents testing used to verify the changes

xylar added 2 commits October 20, 2023 11:39
We want to have a tighter threshold on velocity convergence since
it is better behaved already.
@xylar xylar added clean-up ocean Related to ocean tests or analysis labels Oct 20, 2023
@xylar xylar requested a review from cbegeman October 20, 2023 09:56
@xylar xylar self-assigned this Oct 20, 2023
@xylar
Copy link
Collaborator Author

xylar commented Oct 20, 2023

Testing

I ran the ocean/spherical/qu/geostrophic test case on Chrysalis, once with a normal velocity tolerance that was too strict (1.8) and once with the current one that worked (1.3). In the latter case, the analysis test passed, whereas it failed as it should in the former case with the expected error message:

Order of convergence for water-column thickness: 0.402
Order of convergence for normal velocity: 1.352
Error: order of convergence for normal velocity
  1.352 < min tolerance 1.8
          execution:        ERROR
Exception raised while running the steps of the task
...

@xylar
Copy link
Collaborator Author

xylar commented Oct 20, 2023

@cbegeman, I saw how you handled different tolerances for different fields in sphere_transport and wanted to fix that here as well. A quick review by inspection is all that is needed here.

Copy link
Collaborator

@cbegeman cbegeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xylar Looks great!

@xylar
Copy link
Collaborator Author

xylar commented Oct 20, 2023

Thanks @cbegeman!

@xylar xylar merged commit 03a2cfe into E3SM-Project:main Oct 20, 2023
5 checks passed
@xylar xylar deleted the fix-geostrphic-thresholds branch October 20, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean-up ocean Related to ocean tests or analysis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants