Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add steps for ISOMIP+ init and forcing #151

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Nov 9, 2023

This PR adds to #141 with steps for init and forcing.

I will flesh out this description shortly.

Checklist

  • User's Guide has been updated
  • Developer's Guide has been updated
  • API documentation in the Developer's Guide (api.md) has any new or modified class, method and/or functions listed
  • Documentation has been built locally and changes look as expected
  • Testing comment in the PR documents testing used to verify the changes
  • New tests have been added to a test suite

@xylar xylar added enhancement New feature or request in progress This PR is not ready for review or merging ocean Related to ocean tests or analysis labels Nov 9, 2023
@xylar xylar self-assigned this Nov 9, 2023
@xylar xylar force-pushed the add-isomip-plus-init branch from 039ba8c to ac6fd2c Compare November 14, 2023 19:09
@xylar xylar force-pushed the add-isomip-plus-init branch from ac6fd2c to 0843cdd Compare December 2, 2023 18:28
@xylar xylar force-pushed the add-isomip-plus-init branch 2 times, most recently from 2a6c103 to 9f1a37f Compare September 24, 2024 12:47
xylar added 11 commits December 19, 2024 06:09
The step only computes restoring at the "northern" boundary so
far.
This was previously only the case for thin-film cases.

To accommodate this, we make the minimum ocean column thickness
10 m for non-thin-film cases.  To make the different values for
thin-film and non-thin-film cases more obvious, we use separate
config options for the two.
@xylar xylar force-pushed the add-isomip-plus-init branch from 9f1a37f to 534a3a4 Compare December 19, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in progress This PR is not ready for review or merging ocean Related to ocean tests or analysis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant