-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add steps for ISOMIP+ init and forcing #151
Draft
xylar
wants to merge
11
commits into
E3SM-Project:main
Choose a base branch
from
xylar:add-isomip-plus-init
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xylar
added
enhancement
New feature or request
in progress
This PR is not ready for review or merging
ocean
Related to ocean tests or analysis
labels
Nov 9, 2023
xylar
force-pushed
the
add-isomip-plus-init
branch
from
November 14, 2023 19:09
039ba8c
to
ac6fd2c
Compare
xylar
force-pushed
the
add-isomip-plus-init
branch
from
December 2, 2023 18:28
ac6fd2c
to
0843cdd
Compare
xylar
force-pushed
the
add-isomip-plus-init
branch
2 times, most recently
from
September 24, 2024 12:47
2a6c103
to
9f1a37f
Compare
The step only computes restoring at the "northern" boundary so far.
This was previously only the case for thin-film cases. To accommodate this, we make the minimum ocean column thickness 10 m for non-thin-film cases. To make the different values for thin-film and non-thin-film cases more obvious, we use separate config options for the two.
xylar
force-pushed
the
add-isomip-plus-init
branch
from
December 19, 2024 12:40
9f1a37f
to
534a3a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
in progress
This PR is not ready for review or merging
ocean
Related to ocean tests or analysis
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds to #141 with steps for
init
andforcing
.I will flesh out this description shortly.
Checklist
User's Guide has been updatedDeveloper's Guide has been updatedAPI documentation in the Developer's Guide (api.md
) has any new or modified class, method and/or functions listedDocumentation has been built locally and changes look as expectedTesting
comment in the PR documents testing used to verify the changesNew tests have been added to a test suite