-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port ocean internal wave test #153
Port ocean internal wave test #153
Conversation
TestingAll new tests have been run on chrys with intel, openmpi. The rpe plots are visually identical with the output from Compass. |
3b3fd0a
to
e68d501
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cbegeman, this is excellent! The tests ran fine for me on Chrysalis. I looked through the code and it looks great! The documentation as well.
Feel free to merge as soon as you rebase to fix the conflict. |
e68d501
to
47a39b8
Compare
@xylar Thank you for the review! I have resolved the merge conflicts. |
Here we port the internal gravity wave test case from Compass. This is largely a direct port. The only substantive new code is the transect visualization.
Checklist
api.md
) has any new or modified class, method and/or functions listedTesting
comment in the PR documents testing used to verify the changes