Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port ocean internal wave test #153

Merged
merged 9 commits into from
Jan 8, 2024

Conversation

cbegeman
Copy link
Collaborator

Here we port the internal gravity wave test case from Compass. This is largely a direct port. The only substantive new code is the transect visualization.

Checklist

  • User's Guide has been updated
  • Developer's Guide has been updated
  • API documentation in the Developer's Guide (api.md) has any new or modified class, method and/or functions listed
  • Documentation has been built locally and changes look as expected
  • Testing comment in the PR documents testing used to verify the changes
  • New tests have been added to a test suite

@cbegeman
Copy link
Collaborator Author

Testing

All new tests have been run on chrys with intel, openmpi. The rpe plots are visually identical with the output from Compass.

@cbegeman cbegeman requested a review from xylar November 18, 2023 00:00
@cbegeman cbegeman self-assigned this Nov 18, 2023
@cbegeman cbegeman added enhancement New feature or request ocean Related to ocean tests or analysis labels Nov 18, 2023
@cbegeman cbegeman force-pushed the ocn-port-internal-wave-test branch from 3b3fd0a to e68d501 Compare November 18, 2023 00:06
@cbegeman
Copy link
Collaborator Author

Standard flux-form advection:
image

VLR:
image

Example sections plot:
image

Copy link
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbegeman, this is excellent! The tests ran fine for me on Chrysalis. I looked through the code and it looks great! The documentation as well.

@xylar
Copy link
Collaborator

xylar commented Jan 2, 2024

Feel free to merge as soon as you rebase to fix the conflict.

@cbegeman cbegeman force-pushed the ocn-port-internal-wave-test branch from e68d501 to 47a39b8 Compare January 8, 2024 20:24
@cbegeman
Copy link
Collaborator Author

cbegeman commented Jan 8, 2024

@xylar Thank you for the review! I have resolved the merge conflicts.

@cbegeman cbegeman merged commit 968f24b into E3SM-Project:main Jan 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ocean Related to ocean tests or analysis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants