-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues with shared config files #157
Conversation
This gets set to `True` when `set_shared_config()` gets called.
Remove unused list of shared steps.
We only want to symlink config file for requested tasks
We get the symlinks from the requested task and steps instead so we don't create symlinks to configs for tasks and steps that weren't requested.
TestingI ran all ocean test cases except the 1 and 4 km baroclinic channel RPE tests (which are too expensive) on Chrysalis with Intel and OpenMPI. All tests were successful except manufactured solution, which failed the usual verification test. I also tested #141 after rebasing onto this branch and it fixed the issues with the |
@cbegeman, can you just give this a quick review, probably just by inspection since I think my testing is sufficient? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xylar Great, thanks! I had noticed the second issue so it's nice that you included it here. Approving by visual inspection.
Great, thanks for the rapid response, @cbegeman! |
This merge fixes two main issues with shared config files:
Checklist
Testing
comment in the PR documents testing used to verify the changes