Reorder diags sets #521
Reorder diags sets #521
Conversation
| @@ -188,7 +188,10 @@ run_type = string(default="model_vs_obs") | |||
| # "qbo" requires `ref_final_yr` to be set. | |||
| # "streamflow" requires `streamflow_obs_ts` to be set. | |||
| # "tc_analysis" requires `tc_obs` to be set. | |||
| sets = string_list(default=list("aerosol_aeronet","aerosol_budget","annual_cycle_zonal_mean","cosp_histogram","lat_lon","meridional_mean_2d","polar","zonal_mean_2d","zonal_mean_2d_stratosphere","zonal_mean_xy")) | |||
| # The order of the `sets` list is the order the sets will show up in E3SM Diags. | |||
There was a problem hiding this comment.
I kept the above comments listing sets in alphabetical order, for ease of readability.
zppy/templates/cryosphere.cfg
Outdated
| @@ -1,5 +1,5 @@ | |||
| [e3sm_diags] | |||
| sets = "aerosol_aeronet","aerosol_budget","annual_cycle_zonal_mean","cosp_histogram","diurnal_cycle","enso_diags","lat_lon","meridional_mean_2d","polar","qbo","streamflow","zonal_mean_2d","zonal_mean_2d_stratosphere","zonal_mean_xy" | |||
| sets= "lat_lon","zonal_mean_xy","zonal_mean_2d","polar","cosp_histogram","meridional_mean_2d","enso_diags","qbo","diurnal_cycle","annual_cycle_zonal_mean","zonal_mean_2d_stratosphere","aerosol_aeronet","aerosol_budget" | |||
There was a problem hiding this comment.
"aerosol_aeronet","aerosol_budget" throughout this pull request is why we can't just revert #458 -- doing so would remove those two sets from all these lists.
There was a problem hiding this comment.
"streamflow" is missing
forsyth2
force-pushed
the
reorder-diags
branch
from
7d79818 to
210ee79
Compare
|
@chengzhuzhang @mahf708 Re: E3SM-Project/e3sm_diags#738, this undoes most of #458, while keeping the addition of the two new aerosol sets. Please let me know if the ordering here is acceptable. |
There was a problem hiding this comment.
Thank you @forsyth2! My understanding from @chengzhuzhang is that having lat_lon first is the most important part and your ordering nows is perfect to fix the issue with the htmls being misplaced. Thank you!!!
forsyth2
force-pushed
the
reorder-diags
branch
from
210ee79 to
0dff4e6
Compare
Reorder diags sets by 1) core or speciality and then 2) older to newer, rather than the alphabetical order introduced in #458. The alphabetical order introduced an error to E3SM Diags: E3SM-Project/e3sm_diags#738.
Benefits of alphabetical order (introduced in #458):
diurnal_cycleisn't included insetsby default, so at which point in the list should it be added if you want it?)Benefits of custom order (before #458, again after this pull request):
lat_lon) must be run earlier.