Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported python versions #620

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

altheaden
Copy link
Contributor

@altheaden altheaden commented Sep 23, 2024

Support for Python 3.8 (and lower) has been dropped from conda-forge, so I've updated the lower bounds of supported versions here accordingly.


Updated template from @forsyth2

Issue resolution

This pull request is a minor adjustment that would increment the patch version.

1. Does this do what we want it to do?

Objectives:

  • Make Python 3.9 the oldest supported Python version in zppy.

Required:

  • Product Management: I have confirmed with the stakeholders that the objectives above are correct and complete.
  • Testing: I have added or modified at least one "min-case" configuration file to test this change. Every objective above is represented in at least one cfg.
    • Existing tests are run in an environment already using Python 3.9.
  • Testing: I have considered likely and/or severe edge cases and have included them in testing.

2. Are the implementation details accurate & efficient?

Required:

  • Logic: I have visually inspected the entire pull request myself.

3. Is this well documented?

Required:

  • Documentation: by looking at the docs, a new user could easily understand the functionality introduced by this pull request.
    • This change does not require new documentation.

4. Is this code clean?

Required:

  • Readability: The code is as simple as possible and well-commented, such that a new team member could understand what's happening.
  • Pre-commit checks: All the pre-commits checks have passed.

@xylar
Copy link
Contributor

xylar commented Sep 23, 2024

@forsyth2, could you allow CI to run on this PR and #621? What kind of testing would you like to see for these 2 PRs? We're mostly just trying to apply the same clean up here (and on zstash) that we're applying to other E3SM-related python packages.

@forsyth2
Copy link
Collaborator

@altheaden My original plan was to run the integration tests on this PR after fixing #625 (which #628 I merged this morning does). But it now occurs to me that wouldn't actually show anything new since my dev environment uses Python 9 anyway:

$ python --version
Python 3.9.13

However, I notice the unit test step (CI/CD Build Workflow > Details > Run Unit Tests) shows only 2 unit tests rather than the new number of 22 (post-merging of #628). I thought the CI/CD rebased on the latest main but clearly it does not. In that case, I would say if you can rebase this PR on the latest main and make sure the 22 unit tests pass, this should be good to merge.

I think the same would go for #621 and #627. I do notice #627 has some merge conflicts. (Sorry, I did some pretty extensive refactoring in #628 to make zppy's code easier to understand and to test.)

@altheaden altheaden force-pushed the update-python-version branch from 9109aef to 3468860 Compare October 14, 2024 15:44
@altheaden
Copy link
Contributor Author

@forsyth2 Just did a rebase onto the latest main, can you re-run CI when you get a chance?

@forsyth2 forsyth2 merged commit 6e7df65 into E3SM-Project:main Oct 14, 2024
4 checks passed
@forsyth2
Copy link
Collaborator

Oh I just noticed that zppy/setup.py still has

python_requires=">=3.6",

Should that be changed too, as in E3SM-Project/zstash#351?

@altheaden
Copy link
Contributor Author

@forsyth2 I must have missed that here, I'm sorry - let me create another PR to fix that. Thanks for catching that.

@forsyth2
Copy link
Collaborator

No worries, thanks @altheaden!

@altheaden altheaden deleted the update-python-version branch October 14, 2024 20:22
zhangshixuan1987 pushed a commit to zhangshixuan1987/zppy that referenced this pull request Nov 1, 2024
* Update mypy python version

* Update conda python version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants