-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update supported python versions #620
Conversation
@altheaden My original plan was to run the integration tests on this PR after fixing #625 (which #628 I merged this morning does). But it now occurs to me that wouldn't actually show anything new since my dev environment uses Python 9 anyway:
However, I notice the unit test step (CI/CD Build Workflow > Details > Run Unit Tests) shows only 2 unit tests rather than the new number of 22 (post-merging of #628). I thought the CI/CD rebased on the latest I think the same would go for #621 and #627. I do notice #627 has some merge conflicts. (Sorry, I did some pretty extensive refactoring in #628 to make |
9109aef
to
3468860
Compare
@forsyth2 Just did a rebase onto the latest main, can you re-run CI when you get a chance? |
Oh I just noticed that zppy/setup.py still has
Should that be changed too, as in E3SM-Project/zstash#351? |
@forsyth2 I must have missed that here, I'm sorry - let me create another PR to fix that. Thanks for catching that. |
No worries, thanks @altheaden! |
* Update mypy python version * Update conda python version
Support for Python 3.8 (and lower) has been dropped from
conda-forge
, so I've updated the lower bounds of supported versions here accordingly.Updated template from @forsyth2
Issue resolution
This pull request is a minor adjustment that would increment the patch version.
1. Does this do what we want it to do?
Objectives:
zppy
.Required:
2. Are the implementation details accurate & efficient?
Required:
3. Is this well documented?
Required:
4. Is this code clean?
Required: