-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CI to test secondary ion emission in RZ. #5576
Merged
RemiLehe
merged 15 commits into
ECP-WarpX:development
from
oshapoval:secondary_emission_callback
Jan 31, 2025
Merged
Added CI to test secondary ion emission in RZ. #5576
RemiLehe
merged 15 commits into
ECP-WarpX:development
from
oshapoval:secondary_emission_callback
Jan 31, 2025
+369
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Examples/Tests/secondary_ion_emission/inputs_test_rz_secondary_ion_emission_picmi.py
Fixed
Show fixed
Hide fixed
Examples/Tests/secondary_ion_emission/inputs_test_rz_secondary_ion_emission_picmi.py
Fixed
Show fixed
Hide fixed
EZoni
requested changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @oshapoval! I left some first few comments.
Examples/Tests/secondary_ion_emission/inputs_test_rz_secondary_ion_emission_picmi.py
Show resolved
Hide resolved
for more information, see https://pre-commit.ci
…poval/WarpX into secondary_emission_callback
RemiLehe
reviewed
Jan 30, 2025
RemiLehe
reviewed
Jan 30, 2025
RemiLehe
reviewed
Jan 30, 2025
RemiLehe
approved these changes
Jan 30, 2025
EZoni
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds secondary ion emission through a callback function, allowing secondary electrons to be emitted when an ion hits the embedded boundary. In the following CI test, the random seed was fixed to ensure consistent emission of secondary electrons for reproducibility. We used a secondary electron emission yield (SEY) of 0.4.