Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CI to test secondary ion emission in RZ. #5576

Merged
merged 15 commits into from
Jan 31, 2025

Conversation

oshapoval
Copy link
Member

This PR adds secondary ion emission through a callback function, allowing secondary electrons to be emitted when an ion hits the embedded boundary. In the following CI test, the random seed was fixed to ensure consistent emission of secondary electrons for reproducibility. We used a secondary electron emission yield (SEY) of 0.4.

@oshapoval oshapoval requested review from RemiLehe and EZoni January 18, 2025 03:19
Copy link
Member

@EZoni EZoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @oshapoval! I left some first few comments.

@oshapoval oshapoval requested a review from EZoni January 28, 2025 16:41
@RemiLehe RemiLehe enabled auto-merge (squash) January 30, 2025 18:31
@RemiLehe RemiLehe closed this Jan 30, 2025
auto-merge was automatically disabled January 30, 2025 22:31

Pull request was closed

@RemiLehe RemiLehe reopened this Jan 30, 2025
@RemiLehe RemiLehe enabled auto-merge (squash) January 30, 2025 22:31
@RemiLehe RemiLehe merged commit 69a8a11 into ECP-WarpX:development Jan 31, 2025
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tests Tests and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants