Old MF Wrapper: Warn of no CuPy #5585
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an old code path that does not warn when it implicitly hopes that managed memory is enabled. This adds a warning. In general, we should use the new pyAMReX-ported MultiFabWrapper, which is safer to use.
ax3l
added
backend: cuda
There was a problem hiding this comment.
To avoid the (albeit very small) overhead of executing load_cupy each time _get_field is called, self.cupy_status could instead be set during the _MultiFABWrapper initialization, and in the block that relies on managed memory we can then simply add
libwarpx.amr.Print(self.cupy_status)
What do you think?
|
Note that this code is deleted in PR #5407. If that PR is merged, then this PR is not needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an old code path that does not warn when it implicitly hopes that managed memory is enabled. This adds a warning.
In general, we should use the new pyAMReX-ported MultiFabWrapper, which is safer to use.