Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cam6_4_057: Restore spectral scaling to RRTMGP #1194

Open
wants to merge 4 commits into
base: cam_development
Choose a base branch
from

Conversation

brian-eaton
Copy link
Collaborator

resolves #1193 - Restore spectral scaling to RRTMGP

@brian-eaton brian-eaton added enhancement New feature or request answer changing answer changing tag CoupledEval3 labels Nov 18, 2024
@brian-eaton brian-eaton self-assigned this Nov 18, 2024
@cacraigucar
Copy link
Collaborator

@brianpm - I believe this PR needs you to validate the changes before it moves out of draft status?

@brian-eaton
Copy link
Collaborator Author

Correct. There were some unexpected differences that showed up in Cecile's test. This is in progress.

@cacraigucar cacraigucar requested a review from peverwhee January 13, 2025 23:29
PeterHjortLauritzen added a commit to PeterHjortLauritzen/CAM that referenced this pull request Jan 15, 2025
@cacraigucar cacraigucar assigned nusbaume and unassigned brian-eaton Jan 21, 2025
@cacraigucar cacraigucar changed the title Restore spectral scaling to RRTMGP cam6_4_057: Restore spectral scaling to RRTMGP Jan 21, 2025
@cacraigucar cacraigucar marked this pull request as ready for review January 21, 2025 22:51
Copy link
Collaborator

@peverwhee peverwhee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answer changing answer changing tag CoupledEval3 enhancement New feature or request
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants