Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change date separator in filenames to '-', update bounds metadata #19

Conversation

klindsay28
Copy link
Collaborator

bounds metadata mods fix ESCOMP/MOM_interface#107

New time and time:bounds metadata is

    double time(time) ;
      time:units = "days since 0001-01-01 00:00:00" ;
      time:long_name = "time" ;
      time:axis = "T" ;
      time:calendar = "noleap" ;
      time:bounds = "time_bounds" ;

    double time_bounds(time,nbnd) ;
      time_bounds:units = "days since 0001-01-01 00:00:00" ;
      time_bounds:long_name = "time interval endpoints" ;
      time_bounds:calendar = "noleap" ;

The date separator change goes with PR to https://github.com/ESCOMP/MOM_interface,
so that files with changed names get archived by short-term archiver and testing baseline generation works.
Once that PR is submitted, I will update this PR with a link to it.

@jedwards4b
Copy link
Contributor

Thank you Keith - should this PR be marked as draft until the MOM_interface PR is submitted or can it be merged first?

@klindsay28
Copy link
Collaborator Author

Corresponding MOM_interface PR is ESCOMP/MOM_interface#144

@klindsay28 klindsay28 marked this pull request as ready for review May 26, 2023 15:54
@klindsay28
Copy link
Collaborator Author

The merging of this PR should be coordinated with the merging of the MOM_interface PR.
If one runs with this PR and not the MOM_interface PR, MOM6 output will not get archived by the short-term archiver.

@klindsay28
Copy link
Collaborator Author

I don't appear to have permission to suggest reviewers, so I'm writing here to state that this PR is ready for review.

@jedwards4b jedwards4b requested a review from alperaltuntas May 30, 2023 15:48
@alperaltuntas alperaltuntas merged commit 46b0983 into ESCOMP:master Jun 1, 2023
@klindsay28 klindsay28 deleted the fname_datestrings_and_bounds_metadata branch June 30, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify naming and attributes of time variables on history files to be consistent with other CESM components
3 participants