Update performance baseline checks #4520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add more details to TestStatus logs for base, comp, threshold - append (not overwrite) to perf-baselines to keep history - record sha and date of new blesses
jasonb5
requested changes
Nov 27, 2023
| @@ -429,7 +428,7 @@ def read_baseline_file(baseline_file): | |||
| Value stored in baseline file without comments. | |||
| """ | |||
| with open(baseline_file) as fd: | |||
| lines = [x.strip() for x in fd.readlines() if not x.startswith("#")] | |||
| lines = [x.strip().split(" ")[-1] for x in fd.readlines() if not x.startswith("#")] | |||
|
|
|||
| return "\n".join(lines) | |||
There was a problem hiding this comment.
This needs to be return lines[-1] to return the latest value.
|
@amametjanov Just need the one change, passing pre-commit and tests. I can fix the tests if you'd like. |
amametjanov
force-pushed
the
azamat/baselines/update-perf-info
branch
from
1f0768d to
94d0d8b
Compare
Also add black formatting and update unit tests.
amametjanov
force-pushed
the
azamat/baselines/update-perf-info
branch
from
94d0d8b to
ef22a0c
Compare
|
You can preview documentation at https://esmci.github.io/cime/branch/azamat/baselines/update-perf-info/html/index.html |
jasonb5
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update performance baseline checks:
Test suite: PFS.ne30pg2_r05_oECv3.F2010.chrysalis_intel.bench-noio
Test baseline: same
Test namelist changes: none
Test status: bit for bit
User interface changes?: N
Update gh-pages html (Y/N)?: N