Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark SETUP as FAIL if case.cmpgen_namelists fails #4681

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

samsrabin
Copy link
Contributor

@samsrabin samsrabin commented Sep 13, 2024

Mark SETUP as FAIL rather than PEND if case.cmpgen_namelists fails.

Branched from cime6.0.246 cime6.1.26.

Test suite:
Test baseline:
Test namelist changes:
Test status: [bit for bit, roundoff, climate changing]

Fixes #4680

User interface changes?: No

Update gh-pages html (Y/N)?: N

@samsrabin samsrabin marked this pull request as ready for review September 13, 2024 19:03
@samsrabin
Copy link
Contributor Author

@jedwards4b If you'd like me to rebase this to a more recent CIME tag, let me know.

@jedwards4b
Copy link
Contributor

@samsrabin rebasing may fix the failing e3sm github test

@samsrabin samsrabin force-pushed the namelist-fail-setup-fail branch from 09fe210 to 35305d2 Compare September 13, 2024 20:20
@samsrabin
Copy link
Contributor Author

Good point; done.

@samsrabin
Copy link
Contributor Author

Looks like the cesm nuopc Github test still fails... is that expected?

@jedwards4b jedwards4b self-requested a review September 13, 2024 21:01
Copy link
Contributor

@jedwards4b jedwards4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@jedwards4b jedwards4b merged commit 64b2335 into ESMCI:master Sep 13, 2024
6 of 7 checks passed
@jedwards4b
Copy link
Contributor

Yes, unfortunately it is and the guy that needs to fix it is on family leave.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing: Failed namelist build shows as SETUP PEND
2 participants