Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update poetry certifi version and update tests failing due to mpi-ser… #66

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

jedwards4b
Copy link
Collaborator

@jedwards4b jedwards4b commented Nov 13, 2024

Fixes issue #65

@jedwards4b jedwards4b self-assigned this Nov 13, 2024
@peverwhee peverwhee self-requested a review November 13, 2024 21:47
@peverwhee
Copy link

Thanks @jedwards4b !

I got this error trying to run a test on izumi:

  File "/home/courtneyp/Projects/sima-init-const/bin/git-fleximod", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/home/courtneyp/Projects/sima-init-const/.lib/git-fleximod/git_fleximod/git_fleximod.py", line 348, in main
    submodules_update(gitmodules, root_dir, fxrequired, force)
  File "/home/courtneyp/Projects/sima-init-const/.lib/git-fleximod/git_fleximod/git_fleximod.py", line 244, in submodules_update
    submod.update()
  File "/home/courtneyp/Projects/sima-init-const/.lib/git-fleximod/git_fleximod/submodule.py", line 344, in update
    self.sparse_checkout()
  File "/home/courtneyp/Projects/sima-init-const/.lib/git-fleximod/git_fleximod/submodule.py", line 224, in sparse_checkout
    gitroot = self.root_dir.strip()
              ^^^^^^^^^^^^^^^^^^^
AttributeError: 'PosixPath' object has no attribute 'strip'

If I changed that line (224) in submodule.py to gitroot = self.root_dir, it worked.

@jedwards4b
Copy link
Collaborator Author

@peverwhee Please try again.

Copy link

@peverwhee peverwhee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes my issue! thanks!

@jedwards4b jedwards4b merged commit 1e0c40a into main Nov 13, 2024
1 check passed
@jedwards4b jedwards4b deleted the poetry_and_test_update branch November 13, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants