Allow compile time CRC calculation #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwellbelove
changed the base branch from
development
to
pull-request/#1016-Allow-compile-time-CRC-calculation
…tion' into constexpr_crc
|
The tests fail for C++03. |
jwellbelove
reviewed
Jan 21, 2025
include/etl/frame_check_sequence.h
Outdated
| @@ -107,7 +107,7 @@ namespace etl | |||
| //************************************************************************* | |||
| /// Default constructor. | |||
| //************************************************************************* | |||
| frame_check_sequence() | |||
| ETL_CONSTEXPR14 frame_check_sequence() : frame_check{} | |||
There was a problem hiding this comment.
The CI fails for C++03 syntax check.
You will have to change frame_check{} to frame_check() for C++03 compatibility.
Zob314
commented
Jan 21, 2025
| @@ -241,16 +241,21 @@ namespace etl | |||
| struct crc_table<TAccumulator, Accumulator_Bits, Chunk_Bits, Chunk_Mask, Polynomial, Reflect, 4U> | |||
| { | |||
| //************************************************************************* | |||
| #if !ETL_USING_CPP11 || defined(ETL_FORCE_NO_ADVANCED_CPP) | |||
There was a problem hiding this comment.
Is ETL_FORCE_NO_ADVANCED_CPP supported? It's only in profile.h and some tests, and it seems to break a few things when defined.
I can remove the extra check if it's not supported.
There was a problem hiding this comment.
It looks like ETL_FORCE_NO_ADVANCED_CPP is a redundant macro left over from some early compile options. It's not even documented.
I will mark them for removal.
jwellbelove
merged commit 14b50c6
into
ETLCPP:pull-request/#1016-Allow-compile-time-CRC-calculation
63 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds constexpr to CRC, allowing compile time computation of CRC values.
I also added constexpr specific tests, but I'm really not sure if every CRC type needs a constexpr test. I'm open to suggestions.
Tested in c++11, c++14, c++17, and c++20 with gcc
All the tests were added via Regex pattern matching, so they're all nearly identical.