Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small everest testing adaptions #173

Merged
merged 11 commits into from
Jan 31, 2025
Merged

Small everest testing adaptions #173

merged 11 commits into from
Jan 31, 2025

Conversation

hikinggrass
Copy link
Contributor

@hikinggrass hikinggrass commented Jan 6, 2025 •
edited
Loading

everest-testing:

  • Use websockets on_connect callback with only one parameter instead of the deprecated one with 2
  • Properly await connection close
  • Use ev_add_pip_package, this allows everest-core to automatically install everest-testing into the venv during configure

@hikinggrass
everest-testing: Use RuntimeSettings ctor with MQTTSettings if available
4004cd0 
This is the case in everest-framework >= v0.19.2

Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
Use websockets on_connect callback with only one parameter instead of…
6e6206b 
… the deprecated one with 2

Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
Properly await connection close
9623e46 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
Use ev_add_pip_package, this allows everest-core to automatically ins…
c7cef02 
…tall everest-testing into the venv during configure

Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass
everest-testing: Use MQTT_SERVER_ADDRESS environment variable in get_…
6f66c91 
…runtime_session

Signed-off-by: Kai-Uwe Hermann <[email protected]>
@hikinggrass hikinggrass mentioned this pull request Jan 7, 2025
Draft
@hikinggrass hikinggrass requested a review from andistorm January 31, 2025 12:54
@hikinggrass
Fix copyright header
25b46ce 
Signed-off-by: Kai-Uwe Hermann <[email protected]>
andistorm
andistorm approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@andistorm andistorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐧

@hikinggrass hikinggrass merged commit ba49269 into main Jan 31, 2025
7 checks passed
@hikinggrass hikinggrass deleted the feature/small-everest-testing-adaptions branch January 31, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andistorm andistorm andistorm approved these changes

Assignees
No one assigned
Labels
include-in-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hikinggrass @andistorm