Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constant size arrays as public inputs + small fixes #207

Merged
merged 7 commits into from
Jul 19, 2023
Merged

Constant size arrays as public inputs + small fixes #207

merged 7 commits into from
Jul 19, 2023

Conversation

MirandaWood
Copy link
Contributor

@MirandaWood MirandaWood commented Jul 7, 2023 •
edited
Loading

This PR mainly adds constant arrays as public inputs to a zapp, adapted from changes in #194. It also includes small fixes:

  • Initialising nullifier root in custom constructor
  • Local variable declarations initialised properly in the circuit and node (depending on whether they are in a loop init)
  • Type declarations in circuit for arrays
  • Updates zokrates-worker container to include stdlib fix (this version is somewhat slower on my non-M1 mac, but fast for M1s)

@MirandaWood MirandaWood marked this pull request as ready for review July 11, 2023 09:34
@MirandaWood MirandaWood requested a review from SwatiEY July 11, 2023 09:34
@MirandaWood MirandaWood self-assigned this Jul 11, 2023
@SwatiEY SwatiEY merged commit c860271 into master Jul 19, 2023
@github-actions
Copy link

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SwatiEY SwatiEY SwatiEY approved these changes

Assignees

@MirandaWood MirandaWood

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MirandaWood @SwatiEY