github actions golf

EclipseMenu · Dec 21, 2024 · 8563d5b · 8563d5b
1 parent 4c9155b
commit 8563d5b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -24,7 +24,8 @@ jobs:
         run: |
           mkdir build
           cd build
-          cmake .. -DRIFT_BUILD_TESTS=ON -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_C_COMPILER=clang -G Ninja
+          cmake .. -DRIFT_BUILD_TESTS=ON -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_C_COMPILER=clang \
+          -G Ninja -DCMAKE_C_FLAGS="-Wall -Wextra -Werror" -DCMAKE_CXX_FLAGS="-Wall -Wextra -Werror -std=c++20" \
 
       - name: Build project
         run: cmake --build build

diff --git a/include/rift/value.hpp b/include/rift/value.hpp
@@ -150,7 +150,7 @@ namespace rift {
                 if (isObject()) return getObject();
                 return Object{};
             } else {
-                static_assert(false, "Unsupported type");
+                static_assert(!std::is_same_v<type, type>, "Unsupported type");
             }
             return {};
         }
@@ -171,7 +171,7 @@ namespace rift {
             } else if constexpr (std::is_same_v<type, Object>) {
                 return isObject();
             } else {
-                static_assert(false, "Unsupported type");
+                static_assert(!std::is_same_v<type, type>, "Unsupported type");
             }
             return false;
         }