Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Add Priyansh61 #1086

Merged
merged 1 commit into from
Jun 4, 2022
Merged

Conversation

Priyansh61
Copy link
Contributor

Added Priyansh61 to README.md

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source, little and often 🤓 . Any questions let us know.

Copy link
Contributor

@Pradumnasaraf Pradumnasaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

__
sema-logo  Summary: 👌 This code looks good

Copy link
Contributor

@0xk4b1r 0xk4b1r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ Looks good 🧨. ]

@Priyansh61
Copy link
Contributor Author

Looks good to me!

__ sema-logo sema-logo  Summary: ok_hand This code looks good

Thanks @Pradumnasaraf , you have been a very good mentor for me in my open source journey. From finding how to start on twitter to doing my first pr and joining a community , you have always helped me. Thank you so much.

@Priyansh61
Copy link
Contributor Author

hey @kabir0x23 thanks for reviewing the PR but i just had a question do i need to do anything else to get my PR merged since i dont know why it is still not merged?? BTW sorry for disturbing you.

@NS007-dev
Copy link
Member

@Priyansh61 only a maintainer can merge your pr, so we will have to wait till a maintainer comes and merges it. Hope this helped. Thanks.

@Pradumnasaraf
Copy link
Contributor

Pradumnasaraf commented Jun 4, 2022

Looks good to me!
__ sema-logo sema-logo  

Thanks @Pradumnasaraf , you have been a very good mentor for me in my open source journey. From finding how to start on twitter to doing my first pr and joining a community , you have always helped me. Thank you so much.

Thank you, @Priyansh61 for your kind words and support.

@Pradumnasaraf
Copy link
Contributor

Pradumnasaraf commented Jun 4, 2022

hey @kabir0x23 thanks for reviewing the PR but i just had a question do i need to do anything else to get my PR merged since i dont know why it is still not merged?? BTW sorry for disturbing you.

Hey!, we merge PR after 2 approval (From the maintainers), but I am merging this as this is not affecting any code of development. :)
Happy Open Source

Copy link
Contributor

@Pradumnasaraf Pradumnasaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge! 🚀

__
sema-logo  Summary: 🏆 This code is awesome  |  Tags: Reusable

@Pradumnasaraf Pradumnasaraf merged commit edb99b2 into EddieHubCommunity:main Jun 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants