Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carpet: Add timing::total_threads variable #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rhaas80
Copy link
Member

@rhaas80 rhaas80 commented Aug 8, 2024

@ianhinder's pull request 20 from https://bitbucket.org/eschnett/carpet/pull-requests/20

I would like to be able to analyse output data and determine things like computational cost, and number of cores used as a function of time. This branch has a prototype which satisfies my immediate needs, but might not be the best approach.

  • It would also be nice to have directly the computational cost, which would probably be time_total * total_threads. This would be the cost for the current Cactus segment.
  • Maybe we want cores rather than threads
  • Maybe we want total cores available on the node rather than threads, since this is what is “spent”, even if it is not being used.

Thoughts?

@rhaas80
Copy link
Member Author

rhaas80 commented Aug 8, 2024

Ian, Erik, do you want to champion this? My personal opinions is that I would rather not output this static information at each timestep along with the other timing information though realistically, putting it eg in an extra Cactus group to request output for it less frequently is not going to make much of a difference (plus the number can change in between restarts after all).

@rhaas80
Copy link
Member Author

rhaas80 commented Aug 8, 2024

Maybe also add the number of MPI ranks (for the same reason)? Though I would normally expect such static information to be written out only once and not each timestep.

@rhaas80 rhaas80 requested a review from ianhinder August 8, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants