Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loop: Check for symmetry boundaries in outermost interior loops #300

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Loop: Check for symmetry boundaries in outermost interior loops #300

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
821683e
Loop: Check symmetry boundaries in outermost_int loops
chcheng3 Jul 29, 2024
e0ea421
TestLoopX: Apply periodic and reflection symmetry in test case
chcheng3 Jul 29, 2024
e14cd1a
Merge remote-tracking branch 'upstream/main' into pr_newradx_fix
chcheng3 Oct 22, 2024
a3b4594
Merge pull request #1 from chcheng3/pr_newradx_fix
chcheng3 Oct 22, 2024
afdd439
CarpetX: Include driver.hxx in driver.hxx
chcheng3 Oct 30, 2024
62a7d16
TestLoopX: Use driver.hxx from CarpetX via USES INCLUDE syntax
chcheng3 Oct 30, 2024
c915516
TestLoopX: Restore blocking_factor to default and resize test domain
chcheng3 Oct 30, 2024
bb42c56
Loop: Add description of additional argument for loop_outermost_int
chcheng3 Oct 31, 2024
50af365
Merge branch 'EinsteinToolkit:main' into main
chcheng3 Nov 5, 2024
a7a6a9b
Merge branch 'EinsteinToolkit:main' into main
chcheng3 Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion TestLoopX/configuration.ccl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# Configuration definitions for thorn TestLoopX

REQUIRES Loop
REQUIRES CarpetX Loop
1 change: 1 addition & 0 deletions TestLoopX/interface.ccl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Interface definition for thorn TestLoopX
IMPLEMENTS: TestLoopX

USES INCLUDE HEADER: driver.hxx
USES INCLUDE HEADER: loop.hxx
USES INCLUDE HEADER: loop_device.hxx

Expand Down
2 changes: 1 addition & 1 deletion TestLoopX/src/testloop.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
#include <cctk.h>
#include "CarpetX/CarpetX/src/driver.hxx"
#include <cctk_Arguments.h>
#include <cctk_Parameters.h>
#include <loop.hxx>
#include <loop_device.hxx>
#include <driver.hxx>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd use the double quote form of include using " instead of hte <> form since none of these files are system include files.

See

https://gcc.gnu.org/onlinedocs/cpp/Search-Path.html

for the details (there won't be a difference in Cactus using gcc since we use -I to add the extra paths).

The C99 standard say (in https://en.cppreference.com/w/cpp/preprocessor/include) that the double quote variant

The intent of syntax (2) is to search for the files that are not controlled by the implementation.

ie include files not provided by the compiler.

Exactly where you put that cut-off between " and <> is a matter of some choice it seems.


namespace TestLoopX {
using namespace Loop;
Expand Down