CarpetX: CarpetX errors out when it cycles time levels if those levels are not valid everywhere. #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s are not valid everywhere. This breaks code using presync. This commit causes CarpetX to sync these grid functions instead of erroring out. Co-authored-by: Max Morris <[email protected]>
eschnett
reviewed
Jan 15, 2025
| for (int vi = 0; vi < groupdata.numvars; ++vi) | ||
| bool presync_only = CCTK_EQUALS(presync_mode, "presync-only"); | ||
| if (presync_only && groupdata.do_checkpoint) { | ||
| std::set<int> sync_set; |
There was a problem hiding this comment.
A std::vector<bool>(CCTK_Num_Groups()) would probably be faster.
eschnett
reviewed
Jan 15, 2025
| } | ||
| // check that what we have is correct | ||
| if (groupdata.do_checkpoint) { | ||
| std::set<int> sync_set; |
eschnett
reviewed
Jan 15, 2025
| std::set<int> sync_set; | ||
| for (int tl = (ntls == 1 ? 0 : 1); tl < ntls; ++tl) { | ||
| for (int vi = 0; vi < groupdata.numvars; ++vi) { | ||
| sync_set.insert(gi); |
There was a problem hiding this comment.
That's weird. You insert the same number into the set several times.
|
If I understand, this patch adds code before cycling time levels in presync mode. Is that correct? It doesn't change existing code? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CarpetX: CarpetX errors out when it cycles time levels if those levels are not valid everywhere.
This breaks code using presync-only.
This commit causes CarpetX to sync these grid functions (if presync-only is enabled) instead of erroring out.