CarpetX: avoid features not supported by nvhpc's compiler #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I confirm the this change make CarpetX compile on vista with nvc compilers |
eschnett
reviewed
Jan 16, 2025
eschnett
reviewed
Jan 16, 2025
eschnett
reviewed
Jan 16, 2025
eschnett
reviewed
Jan 16, 2025
eschnett
reviewed
Jan 16, 2025
eschnett
reviewed
Jan 16, 2025
eschnett
requested changes
Jan 16, 2025
|
Alright, I updated the C++ stuff with |
|
@lwJi please click on "approve" if you are happy with the proposed change. |
I can't find a "approve" button on my side |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids two features not supported by nvhpc version nvc++ 24.3 ("nvc++ 24.3-0 linuxarm64 target on aarch64 Linux -tp neoverse-v2"):
The former is the more annoying fix since I added an
#ifdef. If one consider the possible loss in speed due to using a#pragma omp criticalinstead of (possibly) are more optimal implementation via#pragma reduction(...)negligible then one can remove the#ifdef.