Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NewRadX: remove superfluous inheritance from CarpetX #46

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Conversation

rhaas80
Copy link
Member

@rhaas80 rhaas80 commented Oct 7, 2024

No description provided.

@lwJi
Copy link
Collaborator

lwJi commented Oct 8, 2024

you need to rename CarpetX to CarpetXRegrid for thorn TestNewRadX

@lwJi
Copy link
Collaborator

lwJi commented Oct 8, 2024

and scripts/spacetimex.th

@lwJi
Copy link
Collaborator

lwJi commented Oct 8, 2024

unfortunately, Actions of AsterX also depend on this PR. So I updated it

@lwJi lwJi merged commit 11cad12 into main Oct 8, 2024
5 checks passed
@lwJi lwJi deleted the rhaas/no_carpetx branch October 8, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants