Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update "Getting Involved" and "Next Steps" with discord, DAG, Crosslink overview, and simtfl overview. #92

Merged
merged 7 commits into from
Oct 23, 2023
Merged

Update "Getting Involved" and "Next Steps" with discord, DAG, Crosslink overview, and simtfl overview. #92

merged 7 commits into from
Oct 23, 2023

Conversation

nathan-at-least
Copy link
Contributor

@nathan-at-least nathan-at-least commented Oct 19, 2023 •
edited
Loading

This closes #91 and also updates the "Status and Next Steps" page substantially.

This directly extends #87.

@daira daira force-pushed the 91-consolidate-dev-resources branch from 6c56b0a to d0d0a3e Compare October 23, 2023 15:03
@daira daira force-pushed the 91-consolidate-dev-resources branch 2 times, most recently from e07ad48 to a2aa936 Compare October 23, 2023 15:36
@daira
Fix links. Also add some blank space at the end of terminology.md so …
58ffb69 
…that

links scroll to the right place.

Signed-off-by: Daira Emma Hopwood <[email protected]>
@daira daira force-pushed the 91-consolidate-dev-resources branch 2 times, most recently from d07842c to a459a8d Compare October 23, 2023 16:18
daira added 2 commits October 23, 2023 17:25
@daira
More wording improvements, clarifications, and typo fixes.
ee743b7 
Signed-off-by: Daira Emma Hopwood <[email protected]>
@daira
Change "guaranteed finality" to "assured finality" in the
60694ba 
Motivating Finality section.

Signed-off-by: Daira Emma Hopwood <[email protected]>
@daira daira force-pushed the 91-consolidate-dev-resources branch from a459a8d to 60694ba Compare October 23, 2023 16:25
nathan-at-least
nathan-at-least commented Oct 23, 2023
View reviewed changes
Copy link
Contributor Author

@nathan-at-least nathan-at-least left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied one of Daira's suggestions. Unnecessary review which I cannot delete. (It applied a change to a diff that was already replaced.)

@nathan-at-least nathan-at-least merged commit 2d36074 into main Oct 23, 2023
1 check passed
@daira daira deleted the 91-consolidate-dev-resources branch October 23, 2023 19:17
@daira daira mentioned this pull request Oct 25, 2023
Closed
nathan-at-least
nathan-at-least commented Oct 25, 2023
View reviewed changes
Copy link
Contributor Author

@nathan-at-least nathan-at-least left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look good except for the mysterious <pre> whitespace block in src/terminology.md.

src/terminology.md
Comment on lines +44 to +85

<pre>







































</pre>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this diff hunk. Does it force appending a bunch of whitespace? Why?

This was referenced Oct 25, 2023
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daira daira daira left review comments

@ebfull ebfull Awaiting requested review from ebfull

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update "Getting Involved" and "Next Steps" with discord, DAG, Crosslink working doc, and simtfl links.
2 participants
@nathan-at-least @daira