Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #1438

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@ import XCTestDynamicOverlay

extension BalanceFormatterClient: TestDependencyKey {
public static let testValue = Self(
convert: unimplemented("\(Self.self).convert", placeholder: .placeholer)
convert: unimplemented("\(Self.self).convert", placeholder: .placeholder)
)
}

extension BalanceFormatterClient {
public static let noOp = Self(
convert: { _, _, _ in .placeholer }
convert: { _, _, _ in .placeholder }
)
}
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ public struct ZatoshiStringRepresentation: Equatable {
}

extension ZatoshiStringRepresentation {
static let placeholer = Self(Zatoshi(123_456_000))
static let placeholder = Self(Zatoshi(123_456_000))
}

extension ZatoshiStringRepresentation {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ extension CrashReporterClient: DependencyKey {
configure: { canConfigure in
let fileName = "GoogleService-Info.plist"

// checks whether the crash reporter's config file is a dummy_file purposedly placed by the build job or the real one.
// checks whether the crash reporter's config file is a dummy_file purposely placed by the build job or the real one.
// this does not check the integrity of the Plist file for Firebase.
// that's a problem for the library itself.
guard
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ extension ReviewRequestClient: DependencyKey {
userDefaults.setValue(appVersion.appVersion(), Constants.versionKey)
},
syncFinished: {
// synchronizer's sync has been finished successfuly
// synchronizer's sync has been finished successfully
userDefaults.setValue(date.now().timeIntervalSince1970, Constants.latestSyncKey)
}
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,13 @@ extension SDKSynchronizerClient: DependencyKey {
latestState: { synchronizer.latestState },
prepareWith: {
seedBytes,
walletBirtday,
walletBirthday,
walletMode,
name,
keySource in
let result = try await synchronizer.prepare(
with: seedBytes,
walletBirthday: walletBirtday,
walletBirthday: walletBirthday,
for: walletMode,
name: name,
keySource: keySource
Expand Down Expand Up @@ -99,7 +99,7 @@ extension SDKSynchronizerClient: DependencyKey {
var hasTransparentOutputs = false
let outputs = await synchronizer.getTransactionOutputs(for: clearedTransaction)
for output in outputs {
if case .transaparent = output.pool {
if case .transparent = output.pool {
hasTransparentOutputs = true
break
}
Expand Down Expand Up @@ -306,9 +306,9 @@ extension SDKSynchronizerClient: DependencyKey {
}
}

// TODO: [#1313] SDK improvements so a client doesn't need to determing if the transaction isPending
// TODO: [#1313] SDK improvements so a client doesn't need to determine if the transaction isPending
// https://github.com/zcash/ZcashLightClientKit/issues/1313
// Once #1313 is done, cleint will no longer need to call for a `latestHeight()`
// Once #1313 is done, client will no longer need to call for a `latestHeight()`
private extension SDKSynchronizerClient {
static func latestBlockHeight(synchronizer: SDKSynchronizer) async throws -> BlockHeight {
let latestBlockHeight: BlockHeight
Expand Down
4 changes: 2 additions & 2 deletions modules/Sources/Models/TransactionState.swift
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ public struct TransactionState: Equatable, Identifiable {
public var title: String {
switch status {
case .failed:
// TODO: failed shileded is not covered!
// TODO: failed shielded is not covered!
return isSentTransaction
? L10n.Transaction.failedSend
: L10n.Transaction.failedReceive
Expand Down Expand Up @@ -272,7 +272,7 @@ extension TransactionState {
memoCount = transaction.memoCount
self.memos = memos

// TODO: [#1313] SDK improvements so a client doesn't need to determing if the transaction isPending
// TODO: [#1313] SDK improvements so a client doesn't need to determine if the transaction isPending
// https://github.com/zcash/ZcashLightClientKit/issues/1313
// The only reason why `latestBlockHeight` is provided here is to determine pending
// state of the transaction. SDK knows the latestBlockHeight so ideally ZcashTransaction.Overview
Expand Down
2 changes: 1 addition & 1 deletion secantTests/UtilTests/WalletStorageTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ class WalletStorageTests: XCTestCase {

// MARK: - Misc

/// The followings methods are here purposely to not rely on `WalletStorage` in order to test functionality of JUST ONE method at a time
/// The following methods are here purposely to not rely on `WalletStorage` in order to test functionality of JUST ONE method at a time
private extension WalletStorageTests {
private func setData(
account: String = "",
Expand Down