Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

Feature/1176 separate fetching of german common names; Data overrides #1186

Merged

Conversation

chr-schr
Copy link
Contributor

@chr-schr chr-schr commented Feb 12, 2024

Corresponding scraper-data PR: https://github.com/ElektraInitiative/scraper-data/pull/2

This PR supersedes #799

Basics

  • The PR is rebased with current master
  • I added a line to changelog.md
  • Details of what I changed are in the commit messages
  • References to issues, e.g. close #X, are in the commit messages and changelog
  • The buildserver is happy

Checklist

  • I fully described what my PR does in the documentation
  • I fixed all affected documentation
  • I fixed the introduction tour
  • I wrote migrations in a way that they are compatible with already present data
  • I fixed all affected decisions
  • I added automated tests or a manual test protocol
  • I added code comments, logging, and assertions as appropriate
  • I translated all strings visible to the user
  • I mentioned every code or binary not directly written or done by me in reuse syntax
  • I created left-over issues for things that are still to be done
  • Code is conforming to our Architecture
  • Code is conforming to our Guidelines
  • Code is consistent to our Design Decisions
  • Exceptions to any guidelines are documented

First Time Checklist

Review

  • I've tested the code
  • I've read through the whole code
  • I've read through the whole documentation
  • I've checked conformity to guidelines
  • I've checked conformity to requirements
  • I've checked that the requirements are tested

Sorry, something went wrong.

temmey and others added 19 commits August 7, 2023 00:36

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@chr-schr chr-schr marked this pull request as ready for review February 18, 2024 22:12
chr-schr and others added 2 commits February 29, 2024 14:44

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…ommon-names
@chr-schr chr-schr added the please review Review by unspecified person requested label Feb 29, 2024
@chr-schr
Copy link
Contributor Author

@markus2330
The build fails because the file to be inserted into the database is now called finalDataset.csv. It is created by applying overrides to mergedDatasets.csv.
See corresponding scraper-data PR for the updated files: ElektraInitiative/scraper-data#2

@hatchla
Copy link
Contributor

hatchla commented Mar 26, 2024

  • I've tested the code
  • I've read through the whole code
  • I've read through the whole documentation
  • I've checked conformity to guidelines
  • I've checked conformity to requirements
  • I've checked that the requirements are tested

Sorry, something went wrong.

@hatchla hatchla self-requested a review March 26, 2024 10:47
scraper/src/fetch_german_names.js Outdated Show resolved Hide resolved
scraper/src/fetch_german_names.js Show resolved Hide resolved
scraper/src/fetch_german_names.js Outdated Show resolved Hide resolved
scraper/src/merge_datasets.js Outdated Show resolved Hide resolved
scraper/src/fetch_german_names.js Outdated Show resolved Hide resolved
…ommon-names
@chr-schr
Copy link
Contributor Author

@markus2330
I implemented all requested changes
Build will only work after merging https://github.com/ElektraInitiative/scraper-data/pull/2, which contains the new final plants dataset finalDataset.csv
Ready to be merged after the scraper-data PR is merged 😄

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…ommon-names
@chr-schr chr-schr added please merge and removed please review Review by unspecified person requested labels Apr 2, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…ommon-names
@markus2330
Copy link
Contributor

markus2330 commented Apr 4, 2024

I created a left-over here: #1242

  • 228ce507b99b9b8f717fe06a8f2b40bd03f15933b58b46bcaaeac10265ce2df4 finalDataset.csv
  • 1afbf95ea8a25669810af735f151ab786b6c90ac56e449f72bc3ef89d66d7499 Antagonist.csv
  • e96c617b71c7b11b8e20759c4e1ef4cb670fe36c8528078ef7ee6ff7cb404283 Companions.csv

deployed on pr.permaplant.net

EDIT: on pr.permaplant.net in the new folder /data, see commit below

EDIT: Also deployed on dev.permaplant.net

Unverified

No user is associated with the committer email.
@markus2330
Copy link
Contributor

jenkins build please

@markus2330 markus2330 merged commit 197207a into master Apr 4, 2024
1 check passed
@markus2330 markus2330 deleted the feature/1176-separate-fetching-of-german-common-names branch April 4, 2024 13:35
@markus2330 markus2330 mentioned this pull request Apr 4, 2024
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants