-
Notifications
You must be signed in to change notification settings - Fork 13
Remove Blossoms from Frontend #1297
base: master
Are you sure you want to change the base?
Conversation
One open question: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I've tested the code
- I've read through the whole code
- I've read through the whole documentation
- I've checked conformity to guidelines
- I've checked conformity to requirements
- I've checked that the requirements are tested
It would be better to completely remove it, git easily allows to restore it anyway. A TODO in the code is definitely not needed as it would be a completely new feature if ever reintroduced. |
Commented code has been removed. What is still present are the other files relevant to blossoms: gainBlossom.ts and the translation files blossoms.json |
Yes, please go ahead and remove everything you found related to blossoms (except of backend, where we leave it for now). |
Removed all blossom-related files and references from the Frontend |
jenkins build please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- I've tested the code
- I've read through the whole code
- I've read through the whole documentation
- I've checked conformity to guidelines
- I've checked conformity to requirements
- I've checked that the requirements are tested
Summary
Basics
close #X
, are in the commit messages and changelogChecklist
First Time Checklist
Review