Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

enable ctrl+a for text inputs #1337

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

danielsteinkogler
Copy link
Contributor

Basics

  • The PR is rebased with current master
  • I added a line to changelog.md
  • Details of what I changed are in the commit messages
  • References to issues, e.g. close #X, are in the commit messages and changelog
  • The buildserver is happy

Checklist

  • I fully described what my PR does in the documentation
  • I fixed all affected documentation
  • I fixed the introduction tour
  • I wrote migrations in a way that they are compatible with already present data
  • I fixed all affected decisions
  • I added automated tests or a manual test protocol
  • I added code comments, logging, and assertions as appropriate
  • I translated all strings visible to the user
  • I mentioned every code or binary not directly written or done by me in reuse syntax
  • I created left-over issues for things that are still to be done
  • Code is conforming to our Architecture
  • Code is conforming to our Guidelines
  • Code is consistent to our Design Decisions
  • Exceptions to any guidelines are documented

First Time Checklist

Review

  • I've tested the code via issue description
  • I've tested the code via requirements
  • I've tested the code with concurrency (several browsers on the same map)
  • I've read through the code
  • I've read through the documentation
  • I've checked conformity to guidelines
  • I've checked conformity to requirements
  • I've checked that the requirements are automatically tested

@danielsteinkogler danielsteinkogler added the please review Review by unspecified person requested label Apr 23, 2024
@danielsteinkogler danielsteinkogler marked this pull request as ready for review April 23, 2024 20:17
@danielsteinkogler
Copy link
Contributor Author

jenkins build please

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
please review Review by unspecified person requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant