-
Notifications
You must be signed in to change notification settings - Fork 123
Conversation
…e important messages
…issue with search)
…cting a valid instance
Thank you! Let us test this today! Should I merge it in advance so that we can have it on webui.libelektra.org? @ingwinlu Is there a manual action necessary to update webui.libelektra.org or will it automatically fetch the latest docker image once @omnidan pushed the image?
Can you maybe delay the unfolding for some time? Or simply not do it as long as there are too many matches? On the one hand, it is likely that the user will continue typing anyway. On the other hand, a "unfold all" feature might be useful in some cases. |
I can make it unfold if there are less than 10-20 matches (I will test when it starts getting too slow). I agree, it is a useful feature if there are only a handful of results. I will still implement this and then you can merge and I will rebuild the images. |
Unfortunately it is not easily possible to determine a number that is always valid. E.g. Firefox ESR is much slower than a recent Firefox/Chrome. An "unfold more" or even unfolding while scrolling would be the best solution. But I have to admit that this would be a new feature. |
You are right, I will set it to a very low number then (like 10). That should not cause any problems. I think the main use-case for auto-unfold is if you want to find a specific item (e.g. matrnr of a student), that should only result in a handful of matches. |
@markus2330 as I pointed out previously there is a mechanism in place that keeps the deployed image in sync with whatever is |
|
@markus2330 everything should be done now. I will rebuild the docker images when the PR gets merged. |
Thank you for the great work! |
@markus2330 I updated all docker images |
Includes improvements from #2103
I tested everything with Chrome and Firefox ESR.
The demo now includes the real world config (at
user/realworld
).I tested search with the real world config and it did freeze my browser tab when entering a query with a lot of matches (such as "a"). This was a result of a feature that automatically unfolded all search results (which isn't such a good idea for many results).
I also bumped the version and updated the release notes.
I will rebuild the docker images (from
master
) after the PR gets merged.closes #2103