Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Loading Event Functions #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matthewlyons
Copy link

Hello All,

This is my first ever PR so I hope I don’t screw it up too bad. I’ve added a function that fires before the get request called loadingStart and changed the callback function to be loadingEnd to match.

These events allow users to make changes to the DOM outside of the pagination div (ie: show and hide a loading spinner or a modal), or fire off other events like Google Analytics tracking.

I have also added a setting useDefault which is true by default but if set to false removes the function that edits the pagination link to show the loading text.

That’s it. Let me know if there’s anything you’d like me to improve on!

@Cam
Copy link
Member

Cam commented Apr 24, 2020

@matthewlyons This looks great! I’ll review fully ASAP. Nice one! Most of us don’t do anywhere near as well in our first PR. I definitely didn’t 😅

@Cam Cam self-requested a review April 24, 2020 13:47
@matthewlyons
Copy link
Author

Thanks Cam! Let me know if there's anything you'd like me to change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants