Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fixed EsCarousel arrows and allowed customization #1561

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

ericdouglaspratt
Copy link
Collaborator

@ericdouglaspratt ericdouglaspratt commented Nov 25, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

  • Prev/next arrow buttons now appear below the carousel, on either side of the dots (if present), rather than on each side, matching the design and allowing carousel slides to align with page content
  • Increased the spacing between the dots and arrows to meet tap targets criteria
  • Allowed customization of gap between slides, gap between slides and controls, arrow size, and arrow color
  • Fixed the issue where the mobile number of dots (usually more) would briefly appear on larger breakpoints until hydration had a chance to occur and update the number of dots accordingly
  • Reduced the number of slides in the core examples from 12 to 6, in accordance with feedback from design that we don't really ever want to show 12 dots (as you would see on mobile) as that's too many
  • Added a no dots example
  • Added a customization example
  • Updated the autoplay example to behave more like a photo slideshow to showcase different card treatment and to (slightly) better match how we use it on the homepage

Basic example

Screen Shot 2024-11-25 at 3 20 02 PM

Customization example

Screen Shot 2024-11-25 at 3 20 40 PM

πŸ₯Ό Testing

  • Tested locally

🧐 Feedback Requested / Focus Areas

  • Overall

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.
  • I have documented testing approach

Copy link

swarmia bot commented Nov 25, 2024

Copy link
Contributor

@hroth1994 hroth1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Approved with 1 nit and potential TODO 🌟

@ericdouglaspratt ericdouglaspratt merged commit 94dedea into esds-3.0-vue3-primevue Nov 27, 2024
1 check passed
@ericdouglaspratt ericdouglaspratt deleted the ced-2001-finalize-carousel branch November 27, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants