Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XDB/MTK] Read timeout error and workaround #6460

Merged
merged 3 commits into from
Feb 6, 2025
Merged

[XDB/MTK] Read timeout error and workaround #6460

merged 3 commits into from
Feb 6, 2025

Conversation

gvasquezvargas
Copy link
Contributor

@gvasquezvargas gvasquezvargas marked this pull request as ready for review February 3, 2025 11:21
@gvasquezvargas gvasquezvargas requested a review from a team as a code owner February 3, 2025 11:21
@gvasquezvargas gvasquezvargas added the deploy Add this label to a PR and it will automatically be deployed to netlify label Feb 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025 •
edited
Loading

🚀 Deployed on https://deploy-preview-6460--edb-docs-staging.netlify.app

@github-actions github-actions bot temporarily deployed to pull request February 3, 2025 11:49 Inactive
@github-actions github-actions bot temporarily deployed to pull request February 5, 2025 09:06 Inactive
zahid75
zahid75 approved these changes Feb 6, 2025
View reviewed changes
Copy link

@zahid75 zahid75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good.

djw-m
djw-m approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@djw-m djw-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

But would say the EPRS docs really should use headings for navigability rather than bold text for headings.

@gvasquezvargas
Copy link
Contributor Author

LGTM

But would say the EPRS docs really should use headings for navigability rather than bold text for headings.

I agree. Besides, I think we need to split those topics out into new pages for readability. The TOC of the MTK pages is so long it doesn't fit into the right navigation/TOC.

@gvasquezvargas gvasquezvargas merged commit 513c409 into develop Feb 6, 2025
6 checks passed
@gvasquezvargas gvasquezvargas deleted the xdb/mtk/keepalive branch February 6, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabbasb gabbasb gabbasb approved these changes

@zahid75 zahid75 zahid75 approved these changes

@djw-m djw-m djw-m approved these changes

@mlewandowski-edb mlewandowski-edb Awaiting requested review from mlewandowski-edb

Assignees
No one assigned
Labels
deploy Add this label to a PR and it will automatically be deployed to netlify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gvasquezvargas @gabbasb @zahid75 @mlewandowski-edb @djw-m