Enzyme rules for partialsort!
#1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1373 +/- ##
==========================================
- Coverage 75.41% 74.73% -0.68%
==========================================
Files 35 35
Lines 10664 10716 +52
==========================================
- Hits 8042 8009 -33
- Misses 2622 2707 +85 ☔ View full report in Codecov by Sentry. |
|
I can reproduce the Julia 1.7 CI failure locally, but I don't immediately see how to fix it. With this PR and Julia 1.7.0 on Windows: using Enzyme, Test
function f(x)
a = [2.0, 2.5, x, x / 2]
y = partialsort(a, 1:2)
return sum(y)
end
@test autodiff(Forward, f, Duplicated(1.5, 1.0))[1] == 1.5 # Passes
@test autodiff(Forward, f, BatchDuplicated(1.5, (1.0, 2.0)))[1] == (var"1"=1.5, var"2"=3.0) |
|
@jgreener64 I think this is a bug in an older julia. If you just version gate the test, I think it's fine |
|
I think the remaining test failures are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In fixing #880 I saw the need for an Enzyme rule for
partialsort!, which fixes that issue and may be useful elsewhere since we have a rule forsort!.