-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CompatHelper
workflow
#1478
Conversation
d7ea599
to
8c2f5ac
Compare
.github/workflows/CompatHelper.yml
Outdated
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
run: julia -e 'using CompatHelper; CompatHelper.main()' | ||
COMPATHELPER_PRIV: ${{ secrets.DOCUMENTER_KEY }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember correctly, without it, there was an error about permissions. Let's delete it for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1478 +/- ##
==========================================
+ Coverage 73.80% 74.77% +0.96%
==========================================
Files 30 30
Lines 11252 11391 +139
==========================================
+ Hits 8305 8518 +213
+ Misses 2947 2873 -74 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Valentin Churavy <[email protected]>
Yeah I agree that is suboptimal. |
There is an upstream issue for that: JuliaRegistries/CompatHelper.jl#294 |
I disabled it for |
I added other directories to check by
CompatHelper
. Also, I enabled the check for jlls.Before merging this, you should know that at first, it will create many PRs.