Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CompatHelper workflow #1478

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Conversation

prbzrg
Copy link
Contributor

@prbzrg prbzrg commented May 27, 2024

I added other directories to check by CompatHelper. Also, I enabled the check for jlls.
Before merging this, you should know that at first, it will create many PRs.

@vchuravy vchuravy force-pushed the up-compathelper-ci branch from d7ea599 to 8c2f5ac Compare June 6, 2024 17:33
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: julia -e 'using CompatHelper; CompatHelper.main()'
COMPATHELPER_PRIV: ${{ secrets.DOCUMENTER_KEY }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly, without it, there was an error about permissions. Let's delete it for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.77%. Comparing base (74d88b4) to head (8c2f5ac).
Report is 13 commits behind head on main.

Current head 8c2f5ac differs from pull request most recent head 6a03a0c

Please upload reports for the commit 6a03a0c to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1478      +/-   ##
==========================================
+ Coverage   73.80%   74.77%   +0.96%     
==========================================
  Files          30       30              
  Lines       11252    11391     +139     
==========================================
+ Hits         8305     8518     +213     
+ Misses       2947     2873      -74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vchuravy vchuravy merged commit ebe4cf7 into EnzymeAD:main Jun 6, 2024
37 of 47 checks passed
@wsmoses
Copy link
Member

wsmoses commented Jun 6, 2024

@vchuravy @prbzrg can this not open PR's for test which have compat for the main repo?

We shouldn't keep separate compats for both

@vchuravy
Copy link
Member

vchuravy commented Jun 6, 2024

Yeah I agree that is suboptimal.

@vchuravy
Copy link
Member

vchuravy commented Jun 6, 2024

There is an upstream issue for that: JuliaRegistries/CompatHelper.jl#294

@vchuravy
Copy link
Member

vchuravy commented Jun 7, 2024

I disabled it for test again

@prbzrg prbzrg deleted the up-compathelper-ci branch October 19, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants