Workaround breakage in llvm.jl #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
reviewed
Jun 6, 2024
vchuravy
reviewed
Jun 6, 2024
|
x-ref: JuliaLLVM/LLVM.jl#414 |
vchuravy
approved these changes
Jun 6, 2024
|
@vchuravy apparenrlt we need to backported to 11 too see slack |
|
I pushed & tagged a deprecation, so this should be fixed for users. I would recommend pirating internals like that though. It's also not clear to me why you're overriding the function in the first place, https://github.com/EnzymeAD/Enzyme/blob/79e829910a63618e1bb5843b8564031a8345305c/enzyme/Enzyme/CApi.cpp#L913-L919 seems wrong (metadata can be attached to function values, not only instructions). |
|
Yeah but we only needed it to attach to instructions. But it’s awesome that
we won’t need to vendor that
…On Thu, Jun 6, 2024 at 7:04 PM Tim Besard ***@***.***> wrote:
I pushed & tagged a deprecation, so this should be fixed for users.
I would recommend pirating internals like that though. It's also not clear
to me why you're overriding the function in the first place,
https://github.com/EnzymeAD/Enzyme/blob/79e829910a63618e1bb5843b8564031a8345305c/enzyme/Enzyme/CApi.cpp#L913-L919
seems wrong (metadata can be attached to function values, not only
instructions).
—
Reply to this email directly, view it on GitHub
<#1497 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJTUXCVJWRUASHABW553R3ZGCI77AVCNFSM6AAAAABI5AFCZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJTGAYDCOJQGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Enzyme.jl 0.11 only ever supported LLVM.jl v6 so no? |
|
Oh awesome then. And per the llvm.jl patch should we change this now to if
not defined valuemetadatadict
…On Thu, Jun 6, 2024 at 7:12 PM Valentin Churavy ***@***.***> wrote:
apparenrlt we need to backported to 11 too see slack
Enzyme.jl 0.11 only ever supported LLVM.jl v6 so no?
—
Reply to this email directly, view it on GitHub
<#1497 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJTUXEUSGSVXDA6XDFKP53ZGCJ7NAVCNFSM6AAAAABI5AFCZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJTGAZDGMJYGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.