Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interpreter caches #1698

Merged
merged 7 commits into from
Aug 4, 2024
Merged

Fix interpreter caches #1698

merged 7 commits into from
Aug 4, 2024

Conversation

wsmoses
Copy link
Member

@wsmoses wsmoses commented Aug 4, 2024

No description provided.

Copy link
Contributor

github-actions bot commented Aug 4, 2024

Benchmark Results

main 2d8a118... main/2d8a118434601e...
basics/overhead 5.56 ± 0.91 ns 4.34 ± 0.01 ns 1.28
time_to_load 0.451 ± 0.0061 s 0.452 ± 0.0023 s 0.999

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.43%. Comparing base (ff9d320) to head (9d2bcf9).
Report is 37 commits behind head on main.

Files Patch % Lines
src/compiler.jl 83.33% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (ff9d320) and HEAD (9d2bcf9). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (ff9d320) HEAD (9d2bcf9)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1698       +/-   ##
===========================================
- Coverage   96.30%   66.43%   -29.88%     
===========================================
  Files           8       31       +23     
  Lines         406    12932    +12526     
===========================================
+ Hits          391     8591     +8200     
- Misses         15     4341     +4326     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wsmoses
Copy link
Member Author

wsmoses commented Aug 4, 2024

@vchuravy i failed to get this to work on 1.6/1.7 if you have any ideas

@wsmoses wsmoses merged commit c44bf01 into main Aug 4, 2024
34 of 56 checks passed
@wsmoses wsmoses deleted the dbgalloc branch August 4, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants