Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn active shadow tuple to zero #2281

Merged
merged 3 commits into from
Jan 23, 2025
Merged

turn active shadow tuple to zero #2281

merged 3 commits into from
Jan 23, 2025

Conversation

wsmoses
Copy link
Member

@wsmoses wsmoses commented Jan 23, 2025

No description provided.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/rules/jitrules.jl
    • lines 1142-1142
    • lines 1171-1171

Copy link
Contributor

github-actions bot commented Jan 23, 2025

Benchmark Results

main 2b74eb9... main/2b74eb918836b3...
basics/overhead 4.34 ± 0.01 ns 4.64 ± 0.01 ns 0.935
time_to_load 1.12 ± 0.02 s 1.12 ± 0.0031 s 0.997

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/rules/jitrules.jl
    • lines 1142-1142
    • lines 1171-1171

Comment on lines +1850 to +1855
@test 1.0 ≈ dR[1, 1]
@test 1.0 ≈ dR[2, 2]
@test 1.0 ≈ dR[3, 3]
@test 1.0 ≈ dR[4, 4]
@test 1.0 ≈ dR[5, 5]
@test 0.0 ≈ dR[6, 6]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@test 1.0 dR[1, 1]
@test 1.0 dR[2, 2]
@test 1.0 dR[3, 3]
@test 1.0 dR[4, 4]
@test 1.0 dR[5, 5]
@test 0.0 dR[6, 6]
@test 1.0 dR[1, 1]
@test 1.0 dR[2, 2]
@test 1.0 dR[3, 3]
@test 1.0 dR[4, 4]
@test 1.0 dR[5, 5]
@test 0.0 dR[6, 6]

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/rules/jitrules.jl
    • lines 1142-1142
    • lines 1171-1171

Comment on lines +1850 to +1855
@test 1.0 ≈ dR[1, 1]
@test 1.0 ≈ dR[2, 2]
@test 1.0 ≈ dR[3, 3]
@test 1.0 ≈ dR[4, 4]
@test 1.0 ≈ dR[5, 5]
@test 0.0 ≈ dR[6, 6]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@test 1.0 dR[1, 1]
@test 1.0 dR[2, 2]
@test 1.0 dR[3, 3]
@test 1.0 dR[4, 4]
@test 1.0 dR[5, 5]
@test 0.0 dR[6, 6]
@test 1.0 dR[1, 1]
@test 1.0 dR[2, 2]
@test 1.0 dR[3, 3]
@test 1.0 dR[4, 4]
@test 1.0 dR[5, 5]
@test 0.0 dR[6, 6]

@wsmoses wsmoses merged commit a74ec0d into main Jan 23, 2025
27 of 31 checks passed
@wsmoses wsmoses deleted the st branch January 23, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant