Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to exclude columns in the CLI config (feature exists in VS Plugin, adding for parity) #2107

Merged

Conversation

jwyza-pi
Copy link
Contributor

@jwyza-pi jwyza-pi commented Jan 19, 2024

@jwyza-pi
Copy link
Contributor Author

jwyza-pi commented Jan 19, 2024

A couple of questions on this:

  1. Can/Does/Should this functionality apply to Views/Sprocs/Functions? I have it coded that way right now, but wasn't sure if it should work with those.
  2. Right now I'm just throwing an exception with the list of errors, but I don't think we want to do it quite this way. Thoughts?
  3. No tests yet, want to see feedback on 1 & 2 before I add them.

@ErikEJ
Copy link
Owner

ErikEJ commented Jan 19, 2024

Views and tables only

We should ignore the bad column and show a warning in the final warnings summary

@jwyza-pi jwyza-pi marked this pull request as ready for review January 19, 2024 19:36
@jwyza-pi
Copy link
Contributor Author

@ErikEJ - I believe I have this ready for review now.

@jwyza-pi jwyza-pi requested a review from ErikEJ January 22, 2024 13:47
@ErikEJ ErikEJ merged commit 0d22712 into ErikEJ:master Jan 22, 2024
2 checks passed
@jwyza-pi jwyza-pi deleted the feature-2106-add-excluded-columns-to-cli branch January 22, 2024 14:04
@ErikEJ
Copy link
Owner

ErikEJ commented Jan 22, 2024

Thanks! Great addition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add ability to exclude columns in tables in the CLI config
2 participants