-
-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to exclude columns in the CLI config (feature exists in VS Plugin, adding for parity) #2107
Merged
ErikEJ
merged 7 commits into
ErikEJ:master
from
jwyza-pi:feature-2106-add-excluded-columns-to-cli
Jan 22, 2024
Merged
Add ability to exclude columns in the CLI config (feature exists in VS Plugin, adding for parity) #2107
ErikEJ
merged 7 commits into
ErikEJ:master
from
jwyza-pi:feature-2106-add-excluded-columns-to-cli
Jan 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xcluded columns in the CLI.
A couple of questions on this:
|
Views and tables only We should ignore the bad column and show a warning in the final warnings summary |
@ErikEJ - I believe I have this ready for review now. |
ErikEJ
reviewed
Jan 20, 2024
ErikEJ
reviewed
Jan 20, 2024
ErikEJ
reviewed
Jan 20, 2024
ErikEJ
reviewed
Jan 20, 2024
ErikEJ
reviewed
Jan 20, 2024
Thanks! Great addition |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes [Feature] Add ability to exclude columns in tables in the CLI config #2106 and adds the functionality for it.
Reverts part of Issue #2100 - Adds new option to not refresh the object lists in the efcpt-config.json during subsequent scaffolds #2104 in order to support the ability to have excluded columns in the CLI. The reverted portion is the skipping of fetching the schema definition when the
refresh-object-list
isfalse