Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Configure basemap style language sample #1688

Merged
merged 22 commits into from
Mar 6, 2024
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
39988ec
Adding configure basemap style language sample
har13205 Mar 1, 2024
4009a8b
Initializing basemapStyleParameters
har13205 Mar 2, 2024
edd0551
Update ArcGISRuntimeSDKQt_CppSamples/Maps/ConfigureBasemapStyleLangua…
har13205 Mar 4, 2024
71acdd2
Update ArcGISRuntimeSDKQt_CppSamples/Maps/ConfigureBasemapStyleLangua…
har13205 Mar 4, 2024
479515d
Update ArcGISRuntimeSDKQt_CppSamples/Maps/ConfigureBasemapStyleLangua…
har13205 Mar 4, 2024
50c5414
Update ArcGISRuntimeSDKQt_CppSamples/Maps/ConfigureBasemapStyleLangua…
har13205 Mar 4, 2024
0379821
Update ArcGISRuntimeSDKQt_CppSamples/Maps/ConfigureBasemapStyleLangua…
har13205 Mar 4, 2024
d9783d2
Update ArcGISRuntimeSDKQt_CppSamples/Maps/ConfigureBasemapStyleLangua…
har13205 Mar 4, 2024
3783d68
Update ArcGISRuntimeSDKQt_CppSamples/Maps/ConfigureBasemapStyleLangua…
har13205 Mar 4, 2024
a9a465c
Update ArcGISRuntimeSDKQt_CppSamples/Maps/ConfigureBasemapStyleLangua…
har13205 Mar 4, 2024
f64922c
Update ArcGISRuntimeSDKQt_CppSamples/Maps/ConfigureBasemapStyleLangua…
har13205 Mar 4, 2024
1769e6d
Changes as per PR comments
har13205 Mar 4, 2024
8d3364e
Update ArcGISRuntimeSDKQt_CppSamples/Maps/ConfigureBasemapStyleLangua…
har13205 Mar 5, 2024
41e07ec
Update ArcGISRuntimeSDKQt_CppSamples/Maps/ConfigureBasemapStyleLangua…
har13205 Mar 5, 2024
5d36cdf
Changes as per PR comments
har13205 Mar 5, 2024
9f52d51
Update ArcGISRuntimeSDKQt_CppSamples/Maps/ConfigureBasemapStyleLangua…
har13205 Mar 5, 2024
0b36d5b
Update ArcGISRuntimeSDKQt_CppSamples/Maps/ConfigureBasemapStyleLangua…
har13205 Mar 5, 2024
cd68518
Update ArcGISRuntimeSDKQt_CppSamples/Maps/ConfigureBasemapStyleLangua…
har13205 Mar 5, 2024
c4d12b1
Update ArcGISRuntimeSDKQt_CppSamples/Maps/ConfigureBasemapStyleLangua…
har13205 Mar 5, 2024
0860c3d
Changes as per PR comments
har13205 Mar 5, 2024
7a6a3f5
Changes as per PR comments
har13205 Mar 5, 2024
dbc50f4
Adding comment for onCurrentTextChanged
har13205 Mar 5, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update ArcGISRuntimeSDKQt_CppSamples/Maps/ConfigureBasemapStyleLangua…
…ge/ConfigureBasemapStyleLanguage.cpp

Co-authored-by: James Ballard <[email protected]>
  • Loading branch information
har13205 and JamesMBallard authored Mar 4, 2024
commit a9a465cf0f8632dc7e48fe26d5a8f357e94be98c
Original file line number Diff line number Diff line change
@@ -91,7 +91,7 @@ void ConfigureBasemapStyleLanguage::setNewBasemap(bool global, QString language)

basemapStyleParameters->setLanguageStrategy(global? BasemapStyleLanguageStrategy::Global : BasemapStyleLanguageStrategy::Local);
har13205 marked this conversation as resolved.
Show resolved Hide resolved

//A SpecificLanguage setting overrides the LanguageStrategy settings
// A SpecificLanguage setting overrides the LanguageStrategy settings
if (language == "none") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review bracket style.

basemapStyleParameters->setSpecificLanguage("");
} else if (language == "Bulgarian") {