FloatingPanel Revisions
#682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfeinzimer
commented
Apr 12, 2024
| @@ -15,9 +15,7 @@ | |||
| import SwiftUI | |||
|
|
|||
| /// A floating panel is a view that overlays a view and supplies view-related | |||
| /// content. For a map view, for instance, it could display a legend, bookmarks, search results, etc.. | |||
| /// Apple Maps, Google Maps, Windows 10, and Collector have floating panel | |||
| /// implementations, sometimes referred to as a "bottom sheet". | |||
There was a problem hiding this comment.
Overall I'd say the concept of sheets are ubiquitous enough in mobile to the point that we don't need to mention these but if we do want to keep them I did some more research:
-
Apple doesn't seem to have Apple Maps trademarked so I think we're in the clear there. If it was trademarked I think we'd need to include a symbol according to this.
-
Google does have Maps trademarked so I think we'd need to change this to "Google Maps™ mapping service" if we decide to keep it to be compliant with this.
-
Windows 10 is a little murky, I didn't find good info.
21 tasks
mhdostal
approved these changes
Apr 15, 2024
dfeinzimer
added a commit
that referenced
this pull request
Apr 18, 2024
These lines were redundant to information available in the main floating panel doc and some of them were removed in #682
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Responds to this and this comment.