Library/libs/sprintf.c: don't write nul if size == 0

[six809]

In snprintf() and vsnprintf().

Allows use of *snprintf(NULL, 0, ...) without segfault.

[EtchedPixels]

Think it's a shade more complicated to fix properly. Will have a look when I have a bit of time.

[EtchedPixels]

Think it should if (rv < size) so that it does the right thing for overrunning strings too ?

[six809]

EtchedPixels wrote:

Think it should if (rv < size) so that it does the right thing for overrunning strings too ?

I think I tested and the normal case worked ok - as if bufpos was left pointing at the last character, not the one after by the file io. But absolutely make sure I'm not hallucinating memories like some sort of crazed AI. ..ciaran

[EtchedPixels]

will take a look in detail - also if bufpos is ending up stuck on the last char whether the length return is right in that case and stuff..

[six809]

EtchedPixels wrote:

will take a look in detail - also if bufpos is ending up stuck on the last char whether the length return is right in that case and stuff..

Ah no you're absolutely right - and I was hallucinating (or really was fixated on the NULL case I wanted to work). Yes, more required. ..ciaran

[EtchedPixels]

Think we need to check size == 0 at the start of the snprintf routines, and pass size - 1 down for the other cases

commit 6b8aca7