Fix min/max chan amps for all-positive(/neg) data #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if a channel's min and max values are the same sign, the definition of minimum and maximum displayed values was previously improper
|
up! |
raphaelvallat
approved these changes
Feb 17, 2021
|
Looks great to me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Etienne and Raphael,
Currently, Sleep doesn't handle well channels with all-positive or all-negative values, due to the way the maximum and minimum values for display are derived from the channels minimum and maximum values.
I stumbled on this limitation as we load some non-EEG data into Sleep with all-positive values to assist with scoring: here I can't set the minimum value for the
derivedEMGchannel where I wantHere's a little fix that I think does the trick to manage channels with all-positive or all-negative values. There would be other acceptable ways of setting the bounds (eg
self._yminSpin[i].setMinimum(-10. * max(abs(self['min'][i]), abs(self['max'][i])))), feel free to make changes if you see fit!I don't think this interacts in any way with other functionalities but I might be missing something.
Best, Tom