Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes Custom Weapon Reload #418

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

TtroubleTT
Copy link

@TtroubleTT TtroubleTT commented Jan 30, 2025

Description

Describe the changes

  • Fixed issue where when player reloaded custom weapon with high clipsize even if they didn't have ammo equal to that clipsize it would give that gun that clipsize.
  • Fixed issue with players not getting proper ammo back in their inventory or subtracted from their inventory when reloading.

What is the current behavior? (You can also link to an open issue here)

What is the new behavior? (if this is a feature change)

  • Fixes all of the above issues. Now custom firearms will can't reload to max clipsize if they dont have enough ammo and ammo left in inventory is the right amount.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:
N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@louis1706 louis1706 changed the title Custom Weapon Reload Fixes fix: Fixes Custom Weapon Reload Jan 30, 2025
@louis1706 louis1706 merged commit 2c89b59 into ExMod-Team:dev Jan 30, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants